Federico Simoncelli has posted comments on this change.
Change subject: glusterSD: BZ 988299: Deduce gluster volume name from domain metadata ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
-1 for visibility
.................................................... File vdsm/storage/glusterVolume.py Line 18: """ Line 19: Line 20: # Get the pristine remote path (hostname:volname) from MD, Line 21: # so that we don't end up using the mangled volume and/or hostnames. Line 22: rpath = sdCache.produce(self.sdUUID).getMetaParam(REMOTE_PATH) Would it be possible to override getRemotePath() in glusterSD? Line 23: rpath_list = rpath.rsplit(":", 1) Line 24: volfileServer = rpath_list[0] Line 25: # Check for leading '/', since its perfectly valid to say Line 26: # hostname:/volname for gluster mounts.
Line 22: rpath = sdCache.produce(self.sdUUID).getMetaParam(REMOTE_PATH) Line 23: rpath_list = rpath.rsplit(":", 1) Line 24: volfileServer = rpath_list[0] Line 25: # Check for leading '/', since its perfectly valid to say Line 26: # hostname:/volname for gluster mounts. Maybe this part will go away when we'll use glusterSD.getRemotePath() Line 27: if rpath_list[1][0] == '/': Line 28: volname = rpath_list[1][1:] Line 29: else: Line 30: volname = rpath_list[1]