Nir Soffer has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk. ......................................................................
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/45077/8/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 2631: return response.error('hotunplugDisk', e.message) Line 2632: else: Line 2633: self._devices[hwclass.DISK].remove(drive) Line 2634: Line 2635: # Find and remove disk device from vm's conf
this is almost identical to _lookupConfByPath (used into the live merge pat
Good catch, but I think ot is not availble in 3.5, and we need to get this fix there. We will remove the duplication in a future patch. Line 2636: for dev in self.conf['devices'][:]: Line 2637: if (dev['type'] == hwclass.DISK and Line 2638: dev['path'] == drive.path): Line 2639: with self._confLock: