Deepak C Shetty has posted comments on this change.
Change subject: glusterSD: BZ 988299: Deduce gluster volume name from domain metadata ......................................................................
Patch Set 1:
(1 comment)
.................................................... File vdsm/storage/glusterVolume.py Line 18: """ Line 19: Line 20: # Get the pristine remote path (hostname:volname) from MD, Line 21: # so that we don't end up using the mangled volume and/or hostnames. Line 22: rpath = sdCache.produce(self.sdUUID).getMetaParam(REMOTE_PATH) I had thought abt this.. but if we override getRemotePath, then how to get the remotePath when we actually need the mangled path ? Overriding getRemotePath won't help in all cases. In future if we have a need to get the mangled path, then it won't be possible. How about overriding getRealPath in glusterSD .. ? will that work ? Line 23: rpath_list = rpath.rsplit(":", 1) Line 24: volfileServer = rpath_list[0] Line 25: # Check for leading '/', since its perfectly valid to say Line 26: # hostname:/volname for gluster mounts.