Nir Soffer has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor ......................................................................
Patch Set 20:
(1 comment)
http://gerrit.ovirt.org/#/c/25978/20/vdsm/virt/migration.py File vdsm/virt/migration.py:
Line 340: monitorThread.start() Line 341: try: Line 342: yield monitorThread Line 343: finally: Line 344: monitorThread.stop() This can be much more useful as general utility for things that you can start and stop.
@contextmanager def running(thing): thing.start() try: yield finally: thing.stop()
Usage:
self._thread = FooThread() with running(self._thread): do staff and some more Line 345: Line 346: Line 347: class MonitorThread(threading.Thread): Line 348: _MONITOR_TICK = 1.0 # unit: seconds