Nir Soffer has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk. ......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/45077/2/vdsm/virt/vm.py File vdsm/virt/vm.py:
Line 2648: else: Line 2649: hooks.after_disk_hotunplug(driveXml, self.conf, Line 2650: params=drive.custom) Line 2651: self._cleanupDrives(drive) Line 2652: self.saveState()
If vdsm crash after invoking detachDevice, the unplugged disk will still b
I think this should work like this:
- Ask libvirt to remove the device, fail on errors (no state changed) - Remove the drive from vm devices disk and from conf (should never fail) - Save the new state (may fail, we can do nothing about it) Line 2653: Line 2654: return {'status': doneCode, 'vmList': self.status()} Line 2655: Line 2656: def _readPauseCode(self):