Mark Wu has uploaded a new change for review.
Change subject: Extend the range of Vm's niceness to allow increasing cpu shares ......................................................................
Extend the range of Vm's niceness to allow increasing cpu shares
The current range of Vm's niceness is [0, 19], and the default value 0 represnts the biggest cpu shares. So if we want to assign more cpu shares to one vm, we have to give a higher niceness to other vms.This patch extends the range to [-19, 19], which makes the default value 0 be the middle of it. It's more flexible for client to set Vm's niceness.
Change-Id: I5ae55daa5655dbd10c200dfd81ba80d8e71abfb5 Signed-off-by: Mark Wu wudxw@linux.vnet.ibm.com --- M vdsm/libvirtvm.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/6289/1 -- To view, visit http://gerrit.ovirt.org/6289 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I5ae55daa5655dbd10c200dfd81ba80d8e71abfb5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com
Ryan Harper has posted comments on this change.
Change subject: Extend the range of Vm's niceness to allow increasing cpu shares ......................................................................
Patch Set 1: I would prefer that you didn't submit this
If we're going to modify how we control guest cpu shares; I want to do it via the libvirt cpuTune xml element. I imagine the nice is pre-libvirt cpuTune control but since we have cpuTune which supports pinning, cpushares, and hardlimits we should use that instead.
-- To view, visit http://gerrit.ovirt.org/6289 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5ae55daa5655dbd10c200dfd81ba80d8e71abfb5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Mark Wu has posted comments on this change.
Change subject: Extend the range of Vm's niceness to allow increasing cpu shares ......................................................................
Patch Set 1:
Any idea on this one? http://gerrit.ovirt.org/#/c/6290
-- To view, visit http://gerrit.ovirt.org/6289 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5ae55daa5655dbd10c200dfd81ba80d8e71abfb5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Laszlo Hornyak has posted comments on this change.
Change subject: Extend the range of Vm's niceness to allow increasing cpu shares ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/6289 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5ae55daa5655dbd10c200dfd81ba80d8e71abfb5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Ryan Harper has posted comments on this change.
Change subject: Extend the range of Vm's niceness to allow increasing cpu shares ......................................................................
Patch Set 2:
Do we have a use-case where we need additional range? Can we really distinguish between 20 different level of relative performance let alone 39?
Also, if this is getting translated into cpushare cgroup values, why not just use the raw values and avoid the math?
-- To view, visit http://gerrit.ovirt.org/6289 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5ae55daa5655dbd10c200dfd81ba80d8e71abfb5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Extend the range of Vm's niceness to allow increasing cpu shares ......................................................................
Patch Set 2:
I agree with Ryan that it would be cleaner to expose cpu shares as a first-class citizen parameter.
Some prehistory: The niceness conversion that you are touching was supposed to be a means to maintain backward compatibility from previous versions of vdsm, which controlled qemu directly. There, it was important to keep all qemus nicer than vdsm itself, hence the lower bound on niceness.
Now, the bounds are a bit arbitrary, and should probably be just circumvented.
-- To view, visit http://gerrit.ovirt.org/6289 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5ae55daa5655dbd10c200dfd81ba80d8e71abfb5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: Extend the range of Vm's niceness to allow increasing cpu shares ......................................................................
Patch Set 2: I would prefer that you didn't submit this
for visibility
-- To view, visit http://gerrit.ovirt.org/6289 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5ae55daa5655dbd10c200dfd81ba80d8e71abfb5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
Mark Wu has abandoned this change.
Change subject: Extend the range of Vm's niceness to allow increasing cpu shares ......................................................................
Patch Set 2: Abandoned
-- To view, visit http://gerrit.ovirt.org/6289 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I5ae55daa5655dbd10c200dfd81ba80d8e71abfb5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com
vdsm-patches@lists.fedorahosted.org
-
Dan Kenigsberg -
lhornyak＠redhat.com -
Ryan Harper -
wudxw＠linux.vnet.ibm.com