Dan Kenigsberg has uploaded a new change for review.
Change subject: virt: let Engine start a VM on an UNKOWN OS ......................................................................
virt: let Engine start a VM on an UNKOWN OS
This superflouse validation was introduced as a "bandage" to avoid https://bugzilla.redhat.com/716705, where Vdsm failed to recognize VMs with "UNKOWN" os injected to their bios.
Now that we recognize VMs based on guest channels existence, we can let Engine start a VM on whatever host it deems valid.
Backward compatibility caveat: if a VM is started on an UNKOWN os, and then migrated to an old Vdsm (pre ovirt-3.4.2), it would be killed when that old Vdsm is to be restarted. It's not probable that someone would start a long-running VM on an UNKOWN platform, we may want to wait with this patch until ovirt-3.3 is deprecated.
Change-Id: Iee7b3913e76923043daab8fb85854c3290208237 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/API.py 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/32459/1
diff --git a/vdsm/API.py b/vdsm/API.py index 8d1bca6..d6f318f 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -237,11 +237,6 @@ vmParams['vmId']) vmParams['volatileFloppy'] = True
- if caps.osversion()['name'] == caps.OSName.UNKNOWN: - return {'status': {'code': errCode['createErr'] - ['status']['code'], - 'message': 'Unknown host operating system'}} - if 'sysprepInf' in vmParams: if not self._createSysprepFloppyFromInf(vmParams['sysprepInf'], vmParams['floppy']):
Francesco Romani has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/32459/1//COMMIT_MSG Commit Message:
Line 16: Backward compatibility caveat: if a VM is started on an UNKOWN os, and Line 17: then migrated to an old Vdsm (pre ovirt-3.4.2), it would be killed when Line 18: that old Vdsm is to be restarted. It's not probable that someone would Line 19: start a long-running VM on an UNKOWN platform, we may want to wait with Line 20: this patch until ovirt-3.3 is deprecated. Although I believe this is unlikely, I believe it is better to play it safe and wait a bit more before to have this patch in. Besides that, looks fine to me. Line 21: Line 22: Change-Id: Iee7b3913e76923043daab8fb85854c3290208237
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11324/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12267/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12113/ : SUCCESS
automation@ovirt.org has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Francesco Romani has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS ......................................................................
Patch Set 2: Code-Review+1
will verify ASAP
automation@ovirt.org has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS ......................................................................
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
automation@ovirt.org has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS ......................................................................
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Francesco Romani has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS ......................................................................
Patch Set 4: Verified+1
verified with 44232: verification: on RHEL 7.2 host, renamed /etc/redhat-release. This is sufficient to fool VDSM and make it believe it is running on UNKNOWN OS. then, restarted VDSM.
Booted a VM in the host which is running the patched VDSM.
Dan Kenigsberg has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS ......................................................................
Patch Set 4: Code-Review+2
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: let Engine start a VM on an UNKOWN OS ......................................................................
virt: let Engine start a VM on an UNKOWN OS
This superflouse validation was introduced as a "bandage" to avoid https://bugzilla.redhat.com/716705, where Vdsm failed to recognize VMs with "UNKOWN" os injected to their bios.
Now that we recognize our VMs based on guest channels existence, we can let Engine start a VM on whatever host it deems valid.
Backward compatibility caveat: if a VM is started on an UNKOWN os, and then migrated to an old Vdsm (pre ovirt-3.4.2), it would be killed when that old Vdsm is to be restarted. This would only affect users using Fedora-based hosts with ovirt-3.3 and ovirt-3.6 on the same cluster. Users of el-based hypervisors cannot migrate a VM started on a 3.6 host to a 3.3 one since el7->el6 migration is blocked by Engine.
ovirt-3.3 has reached its end of supported life, so we should not care about these purely-theoretical users.
Change-Id: Iee7b3913e76923043daab8fb85854c3290208237 Signed-off-by: Dan Kenigsberg danken@redhat.com Reviewed-on: https://gerrit.ovirt.org/32459 Reviewed-by: Francesco Romani fromani@redhat.com Tested-by: Francesco Romani fromani@redhat.com Continuous-Integration: Jenkins CI --- M vdsm/API.py 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified; Looks good to me, but someone else must approve
automation@ovirt.org has posted comments on this change.
Change subject: virt: let Engine start a VM on an UNKOWN OS ......................................................................
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org
-
automation＠ovirt.org -
Dan Kenigsberg -
fromani＠redhat.com -
Jenkins CI RO