Wenchao Xia has uploaded a new change for review.
Change subject: adjust betterPopenTest.py ......................................................................
adjust betterPopenTest.py
The main function in betterPopenTest is used to check result after popen, it should not include the betterPopen and test class code. If it include and the directory it lies on changes, the import will fail, which means additional python settings should be passed to betterPopen making things more complicate.
Change-Id: I3059df6abb5c261f45720fc1a3b5266314c62e79 Signed-off-by: wenchao xia xiawenc@linux.vnet.ibm.com --- M tests/betterPopenTests.py 1 file changed, 50 insertions(+), 51 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/4585/1 -- To view, visit http://gerrit.ovirt.org/4585 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I3059df6abb5c261f45720fc1a3b5266314c62e79 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: adjust betterPopenTest.py ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.................................................... Commit Message Line 11: code. If it include and the directory it lies on changes, the sorry, I don't understand the issue. Maybe Saggi would. Maybe you can rephrase or state the failure more clearly.
-- To view, visit http://gerrit.ovirt.org/4585 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3059df6abb5c261f45720fc1a3b5266314c62e79 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Wenchao Xia has posted comments on this change.
Change subject: adjust betterPopenTest.py ......................................................................
Patch Set 1: (1 inline comment)
.................................................... Commit Message Line 11: code. If it include and the directory it lies on changes, the betterPopenTest.py contains two parts: nose test and _main(). test case would call betterPopen("python", "betterPopenTest.py") to create a child process executing main(), which would do echo then. The child process do not need to import the test class and betterPopen class, and when I change this file's location, the child process failed on import modules. So I moved away the import and test class in the case of _main() executing.
-- To view, visit http://gerrit.ovirt.org/4585 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3059df6abb5c261f45720fc1a3b5266314c62e79 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: adjust betterPopenTest.py ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4585 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3059df6abb5c261f45720fc1a3b5266314c62e79 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com
Wenchao Xia has posted comments on this change.
Change subject: adjust betterPopenTest.py ......................................................................
Patch Set 2:
comment for visibility.
-- To view, visit http://gerrit.ovirt.org/4585 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3059df6abb5c261f45720fc1a3b5266314c62e79 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com
Bing Bu Cao has posted comments on this change.
Change subject: adjust betterPopenTest.py ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4585 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3059df6abb5c261f45720fc1a3b5266314c62e79 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: adjust betterPopenTest.py ......................................................................
Patch Set 2:
this waits for formal verification.
-- To view, visit http://gerrit.ovirt.org/4585 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3059df6abb5c261f45720fc1a3b5266314c62e79 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: adjust betterPopenTest.py ......................................................................
Patch Set 2: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/156/
-- To view, visit http://gerrit.ovirt.org/4585 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3059df6abb5c261f45720fc1a3b5266314c62e79 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: adjust betterPopenTest.py ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/156/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/4585 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3059df6abb5c261f45720fc1a3b5266314c62e79 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Wenchao Xia xiawenc@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Saggi Mizrahi has posted comments on this change.
Change subject: adjust betterPopenTest.py ......................................................................
Patch Set 2:
betterPopen and it's tests have moved to https://github.com/ficoos/cpopen
Please abandon and resubmit there
Saggi Mizrahi has posted comments on this change.
Change subject: adjust betterPopenTest.py ......................................................................
Patch Set 2: Code-Review-2
Itamar Heim has posted comments on this change.
Change subject: adjust betterPopenTest.py ......................................................................
Patch Set 2:
who can help with verifying this to get closure?
Yaniv Bronhaim has posted comments on this change.
Change subject: adjust betterPopenTest.py ......................................................................
Patch Set 2: Code-Review-1
This patch can be abandoned from vdsm, cpopen package is no longer part of vdsm code. This code can be posted to https://github.com/ficoos/cpopen/ repository for pull request and will be reviewed
thank!
Dan Kenigsberg has abandoned this change.
Change subject: adjust betterPopenTest.py ......................................................................
Abandoned
Cpopen has been spun out of vdsm.
vdsm-patches@lists.fedorahosted.org
-
Dan Kenigsberg -
iheim＠redhat.com -
Jenkins CI RO -
mars＠linux.vnet.ibm.com -
smizrahi＠redhat.com -
xiawenc＠linux.vnet.ibm.com -
ybronhei＠redhat.com