Bruce Bai has uploaded a new change for review.
Change subject: Title: fix some code style consist with pep8 ......................................................................
Title: fix some code style consist with pep8
content: fix some storage code files pep8 style.
Change-Id: I50cf61d9b7815cbdd5571930e3f9be59183a83f4 Signed-off-by: Changming Bai baichm@linux.vnet.ibm.com --- M Makefile.am M vdsm/storage/__init__.py M vdsm/storage/safelease.py M vdsm/storage/storageConstants.py M vdsm/storage/storage_exception.py M vdsm/storage/sync.py 6 files changed, 373 insertions(+), 33 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/4500/1 -- To view, visit http://gerrit.ovirt.org/4500 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I50cf61d9b7815cbdd5571930e3f9be59183a83f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bruce Bai baichm@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Title: fix some code style consist with pep8 ......................................................................
Patch Set 2: (13 inline comments)
Great work! When look at the file again, I find some small comment placement problems.
.................................................... File vdsm/storage/storage_exception.py Line 68: ################################################# I think this block of comment indicate a code section. It tries to say "the two Exception class below are for Validation Exceptions". So the comment is like a section start tag. I suggest you apply the following style:
# aaaaaaaaa # aaaaaaaaa
class Except1(Exception): pass
class Except2(Exception): pass
# aaaaaaaaa # aaaaaaaaa
class Except3(Exception): pass
class Except4(Exception): pass
Line 85: ################################################# Same as line 68.
Line 125: ################################################# Same as line 68.
Line 178: ################################################# Same as line 68.
Line 336: ################################################# Same as line 68.
Line 449: ################################################# Same as line 68.
Line 616: ################################################# Same as line 68.
Line 900: ################################################# Same as line 68.
Line 1015: ################################################# Same as line 68.
Line 1188: ################################################# Same as line 68.
Line 1516: ################################################# Same as line 68.
Line 1603: ################################################# Same as line 68.
Line 1675: ################################################# This block of comment is nicer compared to line 68.
-- To view, visit http://gerrit.ovirt.org/4500 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I50cf61d9b7815cbdd5571930e3f9be59183a83f4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Changming Bai baichm@linux.vnet.ibm.com Gerrit-Reviewer: Changming Bai baichm@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Title: fix some code style consist with pep8 ......................................................................
Patch Set 3: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/4500 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I50cf61d9b7815cbdd5571930e3f9be59183a83f4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Changming Bai baichm@linux.vnet.ibm.com Gerrit-Reviewer: Changming Bai baichm@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Title: fix some code style consist with pep8 ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(9 inline comments)
There are some minor problems in your changes, please correct them.
.................................................... File vdsm/storage/storage_exception.py Line 862: "by this version of VDSM" % version) Miss a space after "unsupported". It should be ("...unsupported " "by..." % version)
Line 871: (sdUUID, expVer, curVer)) Same as line 861.
Line 879: "in procces is unsupported (pool: `%s`)" % (spUUID,)) Same as line 861.
Line 894: "msd %s version (%d)" % Same as line 861.
Line 972: I suggest: ("%s: %s ..." % (self.message ...)) Let the second line align with the first element in parentheses in the upper line.
Line 1184: "in the registered with this VDSM") Same as line 861.
Line 1321: "newsize=%s" % (vgname, lvname, newsize)) Same as line 861.
Line 1494: "mdafree=%s" % (vgname, mdasize, mdafree)) Same as line 861.
Line 1507: "mdafree=%s" % (vgname, mdasize, mdafree)) Same as line 861.
-- To view, visit http://gerrit.ovirt.org/4500 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I50cf61d9b7815cbdd5571930e3f9be59183a83f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Changming Bai baichm@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Zhou Zheng Sheng has posted comments on this change.
Change subject: Title: fix some code style consist with pep8 ......................................................................
Patch Set 1: (1 inline comment)
Line 972 is not your problem. Sorry!
.................................................... File vdsm/storage/storage_exception.py Line 972: It's my browser's problem, your indentation is right, sorry!
-- To view, visit http://gerrit.ovirt.org/4500 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I50cf61d9b7815cbdd5571930e3f9be59183a83f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Changming Bai baichm@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Dan Kenigsberg has abandoned this change.
Change subject: Title: fix some code style consist with pep8 ......................................................................
Abandoned
All pending pep8 issues have been fixed.
vdsm-patches@lists.fedorahosted.org
-
baichm＠linux.vnet.ibm.com -
Dan Kenigsberg -
zhshzhou＠linux.vnet.ibm.com