Peter V. Saveliev has uploaded a new change for review.
Change subject: BZ#855924 -- fix 3.1 -> 3.0 migration again ......................................................................
BZ#855924 -- fix 3.1 -> 3.0 migration again
The issue was that fixing self._vm.conf is not enough -- we should fix self._machineParams, that will work in all the cases.
Signed-off-by: Peter V. Saveliev peet@redhat.com Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=855924 Change-Id: I334cd39cad3eed30c2c3f1efa7085526454a44fb --- M vdsm/vm.py 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/9036/1
diff --git a/vdsm/vm.py b/vdsm/vm.py index 2229882..591ac1a 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -236,15 +236,15 @@ """ # care only about "drives" list, since # "devices" doesn't cause errors - if 'drives' in self._vm.conf: + if 'drives' in self._machineParams: for item in ("cdrom", "floppy"): new_drives = [] - for drive in self._vm.conf['drives']: + for drive in self._machineParams['drives']: if drive['device'] == item: - self._vm.conf[item] = drive['path'] + self._machineParams[item] = drive['path'] else: new_drives.append(drive) - self._vm.conf['drives'] = new_drives + self._machineParams['drives'] = new_drives
def run(self): try:
-- To view, visit http://gerrit.ovirt.org/9036 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I334cd39cad3eed30c2c3f1efa7085526454a44fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com
Peter V. Saveliev has posted comments on this change.
Change subject: BZ#855924 -- fix 3.1 -> 3.0 migration again ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/9036 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I334cd39cad3eed30c2c3f1efa7085526454a44fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com
Gal Hammer has posted comments on this change.
Change subject: BZ#855924 -- fix 3.1 -> 3.0 migration again ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/9036 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I334cd39cad3eed30c2c3f1efa7085526454a44fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#855924 -- fix 3.1 -> 3.0 migration again ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
I should have thought of that :-(.
How come this got verified earlier? May I ask for an independent verification this time?
.................................................... File vdsm/vm.py Line 255: self.status['progress'] = 10 Line 256: MigrationSourceThread._ongoingMigrations.acquire() Line 257: try: Line 258: self.log.debug("migration semaphore acquired") Line 259: # patch VM config for targets < 3.1 oops. Seems that this should be tucked inside _setupRemoteMachineParams() Line 260: self._patchConfigForLegacy() Line 261: if not mstate: Line 262: self._vm.conf['_migrationParams'] = { Line 263: 'dst': self._dst,
-- To view, visit http://gerrit.ovirt.org/9036 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I334cd39cad3eed30c2c3f1efa7085526454a44fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#855924 -- fix 3.1 -> 3.0 migration again ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/9036 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I334cd39cad3eed30c2c3f1efa7085526454a44fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com
Vinzenz Feenstra has posted comments on this change.
Change subject: BZ#855924 -- fix 3.1 -> 3.0 migration again ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/9036 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I334cd39cad3eed30c2c3f1efa7085526454a44fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com
Peter V. Saveliev has posted comments on this change.
Change subject: BZ#855924 -- fix 3.1 -> 3.0 migration again ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/9036 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I334cd39cad3eed30c2c3f1efa7085526454a44fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com
Peter V. Saveliev has posted comments on this change.
Change subject: BZ#855924 -- fix 3.1 -> 3.0 migration again ......................................................................
Patch Set 2:
verified by Pavel
-- To view, visit http://gerrit.ovirt.org/9036 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I334cd39cad3eed30c2c3f1efa7085526454a44fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#855924 -- fix 3.1 -> 3.0 migration again ......................................................................
Patch Set 2:
Thanks!
-- To view, visit http://gerrit.ovirt.org/9036 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I334cd39cad3eed30c2c3f1efa7085526454a44fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#855924 -- fix 3.1 -> 3.0 migration again ......................................................................
BZ#855924 -- fix 3.1 -> 3.0 migration again
The issue was that fixing self._vm.conf is not enough -- we should fix self._machineParams, that will work in all the cases.
Signed-off-by: Peter V. Saveliev peet@redhat.com Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=855924 Change-Id: I334cd39cad3eed30c2c3f1efa7085526454a44fb --- M vdsm/vm.py 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Peter V. Saveliev: Verified
-- To view, visit http://gerrit.ovirt.org/9036 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I334cd39cad3eed30c2c3f1efa7085526454a44fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com
vdsm-patches@lists.fedorahosted.org