Federico Simoncelli has uploaded a new change for review.
Change subject: lvm: refresh on mda permission mismatch ......................................................................
lvm: refresh on mda permission mismatch
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=905665 Change-Id: I6a77b967a057329a90499d7707074befe756b68a Signed-off-by: Federico Simoncelli fsimonce@redhat.com --- M vdsm/storage/lvm.py 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/20121/1
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py index 0c2964e..3686570 100644 --- a/vdsm/storage/lvm.py +++ b/vdsm/storage/lvm.py @@ -1299,6 +1299,9 @@ changelv(vg, lv, ("--permission", permission)) except se.StorageException: l = getLV(vg, lv) + if l.attr.permission == 'R': + refreshLV(vg, lv) + l = getLV(vg, lv) if l.writeable == rw: # Ignore the error since lv is now rw, hoping that the error was # because lv was already rw, see BZ#654691. We may hide here
Federico Simoncelli has posted comments on this change.
Change subject: lvm: refresh on mda permission mismatch ......................................................................
Patch Set 1:
(1 comment)
.................................................... File vdsm/storage/lvm.py Line 1299: changelv(vg, lv, ("--permission", permission)) Line 1300: except se.StorageException: Line 1301: l = getLV(vg, lv) Line 1302: if l.attr.permission == 'R': Line 1303: refreshLV(vg, lv) I am still not convinced that this is the appropriate fix. I'd prefer to fix this in lvm. Line 1304: l = getLV(vg, lv) Line 1305: if l.writeable == rw: Line 1306: # Ignore the error since lv is now rw, hoping that the error was Line 1307: # because lv was already rw, see BZ#654691. We may hide here
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: refresh on mda permission mismatch ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4937/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4051/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4861/ : SUCCESS
Ayal Baron has posted comments on this change.
Change subject: lvm: refresh on mda permission mismatch ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
.................................................... File vdsm/storage/lvm.py Line 1299: changelv(vg, lv, ("--permission", permission)) Line 1300: except se.StorageException: Line 1301: l = getLV(vg, lv) Line 1302: if l.attr.permission == 'R': Line 1303: refreshLV(vg, lv) That was nack'd by lvm iirc? Line 1304: l = getLV(vg, lv) Line 1305: if l.writeable == rw: Line 1306: # Ignore the error since lv is now rw, hoping that the error was Line 1307: # because lv was already rw, see BZ#654691. We may hide here
Itamar Heim has posted comments on this change.
Change subject: lvm: refresh on mda permission mismatch ......................................................................
Patch Set 1:
ping?
Itamar Heim has abandoned this change.
Change subject: lvm: refresh on mda permission mismatch ......................................................................
Abandoned
abandoning per no reply. please restore if still relevant.
vdsm-patches@lists.fedorahosted.org