Change in vdsm[master]: Related to BZ#744704 - Do not stop SPM task if in 'racquirin...
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: Related to BZ#744704 - Do not stop SPM task if in 'racquiring' state
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/storage/task.py
Line 149: recovered: [recovering],
Line 150: failed: [recovering, aborting, raborting],
Line 151: }
Line 152: _done = [finished, recovered, failed]
Line 153: _recovering = [racquiring, recovering]
I used list because it was already used in all different occurrences in this particular code. So, let's stay compatible with rest code.
It was very specific change in very complicated and ugly code and the last thing that we need here it's massive changes.
Line 154:
Line 155:
Line 156: def __init__(self, state = None):
Line 157: try:
--
To view, visit http://gerrit.usersys.redhat.com/1042
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36459bea9cfe9b095f2cfb8d88cc142d248c77a4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: Related to BZ#744704 - Do not stop SPM task if in 'racquirin...
by ewarszaw＠redhat.com
Eduardo Warszawski has posted comments on this change.
Change subject: Related to BZ#744704 - Do not stop SPM task if in 'racquiring' state
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/task.py
Line 149: recovered: [recovering],
Line 150: failed: [recovering, aborting, raborting],
Line 151: }
Line 152: _done = [finished, recovered, failed]
Line 153: _recovering = [racquiring, recovering]
Use tuples or since all this stuff is complicated enough convert the task.state to an object with all this rules.
Line 154:
Line 155:
Line 156: def __init__(self, state = None):
Line 157: try:
--
To view, visit http://gerrit.usersys/1042
To unsubscribe, visit http://gerrit.usersys/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36459bea9cfe9b095f2cfb8d88cc142d248c77a4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: Adding shared raw disk feature.
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: Adding shared raw disk feature.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(6 inline comments)
....................................................
Commit Message
Line 10: Use
Line 11: drive=GUID:<guid>,
Line 12: or
Line 13: drive=UUID:<uuid>,
Line 14: Note the mandatory ','
Why it's mandatory? you can split(',') without it
Line 15:
Line 16: Change-Id: Ib417bd6423773db382826d6255e8cbeafd333116
Line 17
Line 18
....................................................
File vdsm/clientIF.py
Line 556: if res['status']['code']:
Line 557: raise vm.VolumeError(drive)
Line 558: path = res['path']
Line 559: #Another drive dict type
Line 560: elif drive.has_key("GUID") and os.path.exists(os.path.join("/dev/mapper", drive["GUID"])):
Did we agree about 'drive' changing?
Line 561: path = os.path.join("/dev/mapper", drive["GUID"])
Line 562: elif drive.has_key("UUID"):
Line 563: rc, out, err = storage.misc.execCmd(["blkid", "-U", drive["UUID"]], sudo=False)
Line 564: if not out or rc != 0:
Line 558: path = res['path']
Line 559: #Another drive dict type
Line 560: elif drive.has_key("GUID") and os.path.exists(os.path.join("/dev/mapper", drive["GUID"])):
Line 561: path = os.path.join("/dev/mapper", drive["GUID"])
Line 562: elif drive.has_key("UUID"):
I think we saw together that blkid is redundant
Line 563: rc, out, err = storage.misc.execCmd(["blkid", "-U", drive["UUID"]], sudo=False)
Line 564: if not out or rc != 0:
Line 565: self.log.info("blkid failed for UUID: %s" % drive)
Line 566: raise vm.VolumeError(drive)
Line 567: else:
Line 568: path = out[0]
Line 569: #For BC sake: a path as a string.
Line 570: elif not drive:
Line 571: path = drive
Is drive == None is OK?
Line 572: elif os.path.exists(drive):
Line 573: path = drive
Line 574: self.log.info("prepared volume path: %s" % path)
Line 575: return path
Line 580: try:
Line 581: result = self.irs.teardownVolume(drive['domainID'], drive['poolID'],
Line 582: drive['imageID'], drive['volumeID'])
Line 583: except KeyError:
Line 584: self.log.info("Avoiding tear down drive %s", str(drive))
why not exception? why not like in _prepareVolumePath?
Line 585:
Line 586: return result['status']['code']
Line 587:
Line 588: def create(self, vmParams):
....................................................
File vdsm/vm.py
Line 416: res = self.cif.irs.getVolumeSize(drive['domainID'],
Line 417: drive['poolID'], drive['imageID'],
Line 418: drive['volumeID'])
Line 419: except KeyError:
Line 420: self.log.info("Ignoring drive %s", str(drive))
Why you need it? We definitely want to raise exception here.
Line 421: else:
Line 422: drive['truesize'] = res['truesize']
Line 423: drive['apparentsize'] = res['apparentsize']
Line 424: drive['blockDev'] = not self.cif.irs.getStorageDomainInfo(
--
To view, visit http://gerrit.usersys.redhat.com/1064
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib417bd6423773db382826d6255e8cbeafd333116
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: Generalize _parseDriveSpec dictionaries.
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: Generalize _parseDriveSpec dictionaries.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Did we agree about changing drives interface?
If we don't, this patch is redundant.
....................................................
File vdsm_cli/vdsClient.py
Line 1341:
Line 1342: #TODO: Remove this and the references to domainID (etc) key.
Line 1343: def _splitDriveSpecItems(self, item):
Line 1344: """
Line 1345: BC is BC.
sorry, but what is BC ?
Line 1346: """
Line 1347: key, value = item.split(":", 1)
Line 1348: if key in ("domain", "pool", "image", "volume"):
Line 1349: key = "%sID" % key
Line 1353: """
Line 1354: ',' means dict. (!)
Line 1355: """
Line 1356: if ',' in spec:
Line 1357: return dict(self._splitDriveSpecItems(item) for item in spec.split(',') if item != "")
minor comment:
more clear will be ' if item ' instead of ' if item != "" '
Line 1358: return spec
Line 1359:
Line 1360: def do_addNetwork(self, args):
Line 1361: params = self._eqSplit(args)
--
To view, visit http://gerrit.usersys.redhat.com/1063
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24350c099a92923323a221c909c53855a2906ece
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: Fix lock release and reversed SPM logic.
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Fix lock release and reversed SPM logic.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 431: else:
Line 432: cls.log.debug("master `%s` is not mounted, skipping", master)
Line 433:
Line 434: def stopSpm(self, force=False):
Line 435: self.lock.acquire()
'with' is prettier.
Line 436: try:
Line 437: if not force and self.getSpmRole() and SPM_FREE:
Line 438: return True
Line 439:
--
To view, visit http://gerrit.usersys.redhat.com/1066
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e2335163e45dc601d6779b45beb03d67e997692
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: configure.ac: find scsi_id on Fedora 16, too.
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configure.ac: find scsi_id on Fedora 16, too.
......................................................................
configure.ac: find scsi_id on Fedora 16, too.
Change-Id: Ic2b276931ddb31d01f7438928f931e3b951d3b56
---
M configure.ac
M vdsm/constants.py.in.in
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Haim Ateya: Verified
--
To view, visit http://gerrit.usersys.redhat.com/1065
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2b276931ddb31d01f7438928f931e3b951d3b56
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: configure.ac: find scsi_id on Fedora 16, too.
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: configure.ac: find scsi_id on Fedora 16, too.
......................................................................
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1065
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2b276931ddb31d01f7438928f931e3b951d3b56
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: Add the systemd support for bootstrap
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add the systemd support for bootstrap
......................................................................
Add the systemd support for bootstrap
Change-Id: I118256a15ddf442dc96168ab04db5b89627c83e3
---
M configure.ac
M vdsm_reg/deployUtil.py.in
2 files changed, 33 insertions(+), 7 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1043
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I118256a15ddf442dc96168ab04db5b89627c83e3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: Add the systemd support for bootstrap
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Add the systemd support for bootstrap
......................................................................
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1043
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I118256a15ddf442dc96168ab04db5b89627c83e3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
12 years, 6 months
Change in vdsm[master]: RPM changes for Fedora
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: RPM changes for Fedora
......................................................................
RPM changes for Fedora
Change-Id: I5cc880f8579b254f49981d88f4045ac124559458
---
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm_hooks/faqemu/Makefile.am
R vdsm_hooks/faqemu/vdsm-faqemu
4 files changed, 167 insertions(+), 154 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/1023
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cc880f8579b254f49981d88f4045ac124559458
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
12 years, 6 months