June 2013 - vdsm-patches - Fedora Mailing-Lists

Change in vdsm[master]: NetReload: netmodels for addNetwork

by asegurap＠redhat.com

Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ...................................................................... Patch Set 21: Verified -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in vdsm[master]: NetReload: netmodels for addNetwork

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ...................................................................... Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2546/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1722/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2619/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in vdsm[master]: NetReload: netmodels for addNetwork

by wudxw＠linux.vnet.ibm.com

Mark Wu has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ...................................................................... Patch Set 19: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/netmodels.py Line 167: slaves = [] Line 168: for nic in nics: Line 169: nicVlans = tuple(_netinfo.getVlansForIface(nic)) Line 170: nicNet = _netinfo.getNetworkForIface(nic) Line 171: nicBond = _netinfo.getBondingForNic(name) should be nicBond = _netinfo.getBondingForNic(nic). Sorry not finding this problem before. It also could be a mistake existing in my suggestions. Line 172: if nicVlans or nicNet or nicBond and nicBond != name: Line 173: raise ConfigNetworkError( Line 174: ne.ERR_USED_NIC, 'nic %s already used by %s' % Line 175: (nic, nicVlans or nicNet or nicBond)) -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in vdsm[master]: NetReload: netmodels for addNetwork

by wudxw＠linux.vnet.ibm.com

Mark Wu has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ...................................................................... Patch Set 19: No score (1 inline comment) .................................................... File lib/vdsm/netinfo.py Line 446: return d Line 447: Line 448: Line 449: def isVlanned(dev): Line 450: return os.path.exists(PROC_NET_VLAN + dev) OR: len(list(_netinfo.getVlansForIface(dev))) > 0 Line 451: Line 452: Line 453: def getVlanDevice(vlan): Line 454: """ Return the device of the given VLAN. """ -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in vdsm[master]: NetReload: netmodels for addNetwork

by wudxw＠linux.vnet.ibm.com

Mark Wu has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ...................................................................... Patch Set 19: I would prefer that you didn't submit this (2 inline comments) .................................................... File lib/vdsm/netinfo.py Line 446: return d Line 447: Line 448: Line 449: def isVlanned(dev): Line 450: return os.path.exists(PROC_NET_VLAN + dev) it looks kernel only export vlan info using the file name of vlan itself, not the interface it sits on. the file name should read like /proc/net/vlan/eth1.10, so we can't tell if an infterface is used as a slave of vlan by this way. Actually, I tried to find out this kind of link from the info exported by kernel, but failed. So we have to parsing the files under ' /proc/net/vlan', that's what the function vlans() does. Probably we still need resort to netinfo.vlans: return dev in [v['iface'] for v in _netinfo.vlans.values()] Line 451: Line 452: Line 453: def getVlanDevice(vlan): Line 454: """ Return the device of the given VLAN. """ .................................................... File vdsm/netconf/ifcfg.py Line 97: netmask=netmask, gateway=gateway, Line 98: bootproto=bootproto, **opts) Line 99: if not netinfo.isVlanned(bond.name): Line 100: for slave in bond.slaves: Line 101: if not netinfo.isVlanned(slave.name): anyway, the check here is not necessary. Isn't it done in Bond.objectivize(), so you could call ifdown(slave.name) unconditionally. Line 102: ifdown(slave.name) Line 103: for slave in bond.slaves: Line 104: slave.configure(bonding=bond.name, **opts) Line 105: ifup(bond.name, async) -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in vdsm[master]: NetReload: netmodels for addNetwork

by asegurap＠redhat.com

Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ...................................................................... Patch Set 19: Verified -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in vdsm[master]: NetReload: netmodels for addNetwork

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ...................................................................... Patch Set 19: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2544/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1720/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2617/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in vdsm[master]: NetReload: netmodels for addNetwork

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ...................................................................... Patch Set 18: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2543/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1719/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2616/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in vdsm[master]: NetReload: netmodels for addNetwork

by asegurap＠redhat.com

Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ...................................................................... Patch Set 17: (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 95: bondingOptions=bond.options, Line 96: mtu=bond.mtu, ipaddr=ipaddr, Line 97: netmask=netmask, gateway=gateway, Line 98: bootproto=bootproto, **opts) Line 99: if not netinfo.isVlanned(bond.name): This check is still necessary because Bond.objectivize can be used with implicit bonding. Line 100: for slave in bond.slaves: Line 101: if not netinfo.isVlanned(slave.name): Line 102: ifdown(slave.name) Line 103: for slave in bond.slaves: -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

Change in vdsm[master]: NetReload: netmodels for addNetwork

by Jenkins CI RO

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ...................................................................... Patch Set 17: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2542/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1718/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2615/ : FAILURE -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvallare(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches June 2013