vdsm-patches December 2014

vdsm-patches@lists.fedorahosted.org

42 participants
734 discussions

Change in vdsm[ovirt-3.5]: Revert "supervdsm: Add zombiereaper to supervdsm"
by Jenkins CI RO 03 Dec '14

03 Dec '14

oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert "supervdsm: Add zombiereaper to supervdsm" ...................................................................... Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/131/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/131/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/131/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/134/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/35802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90a76ad689938cc36fd9adbf73bd16e9a408cbb5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-3.5]: Revert "supervdsm: Add zombiereaper to supervdsm"
by Dan Kenigsberg 03 Dec '14

03 Dec '14

Dan Kenigsberg has submitted this change and it was merged. Change subject: Revert "supervdsm: Add zombiereaper to supervdsm" ...................................................................... Revert "supervdsm: Add zombiereaper to supervdsm" Introduction of zombiereaper is causing communication failures between vdsm and supervdsm. The change register signal handler which causes multiprocessing to fail. There was python bug opened to fix multiprocessing issue but it was not backported to 2.6. This reverts commit 262550421bd169a04bc5f795c5b95ba0e903b4e. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1168217 Change-Id: I90a76ad689938cc36fd9adbf73bd16e9a408cbb5 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Related-To: http://bugs.python.org/issue17097 Reviewed-on: http://gerrit.ovirt.org/35802 Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> Tested-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/supervdsmServer 1 file changed, 15 insertions(+), 23 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90a76ad689938cc36fd9adbf73bd16e9a408cbb5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in vdsm[ovirt-3.5]: Revert "supervdsm: Add zombiereaper to supervdsm"
by Dan Kenigsberg 03 Dec '14

03 Dec '14

Dan Kenigsberg has posted comments on this change. Change subject: Revert "supervdsm: Add zombiereaper to supervdsm" ...................................................................... Patch Set 5: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90a76ad689938cc36fd9adbf73bd16e9a408cbb5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-3.5]: Revert "supervdsm: Add zombiereaper to supervdsm"
by Dan Kenigsberg 03 Dec '14

03 Dec '14

Dan Kenigsberg has posted comments on this change. Change subject: Revert "supervdsm: Add zombiereaper to supervdsm" ...................................................................... Patch Set 4: copying score -- To view, visit http://gerrit.ovirt.org/35802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90a76ad689938cc36fd9adbf73bd16e9a408cbb5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-3.5]: Revert "supervdsm: Add zombiereaper to supervdsm"
by Dan Kenigsberg 03 Dec '14

03 Dec '14

Dan Kenigsberg has posted comments on this change. Change subject: Revert "supervdsm: Add zombiereaper to supervdsm" ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90a76ad689938cc36fd9adbf73bd16e9a408cbb5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-3.5]: irs: Directly register domain state change callbacks
by alitke＠redhat.com 02 Dec '14

02 Dec '14

Hello Nir Soffer, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/35809 to review the following change. Change subject: irs: Directly register domain state change callbacks ...................................................................... irs: Directly register domain state change callbacks Currently, domain state change callbacks aren't actually registered until a storage pool is connected. In a hosted engine environment there is not a traditional storage pool associated with the storage domain that is hosting the engine VM so in this case the event doesn't get registered. Since storage pools are becoming deprecated, there is no reason to delay callback registration based on connectStoragePool. Change-Id: I28d4f1af4f94da1a8e3511abbe160ea66e81daad Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1157421 Signed-off-by: Adam Litke <alitke(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/35369 Reviewed-by: Nir Soffer <nsoffer(a)redhat.com> Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/storage/hsm.py 1 file changed, 2 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/35809/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 0f6930b..45f1694 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -362,8 +362,6 @@ oop.setDefaultImpl(config.get('irs', 'oop_impl')) - self.domainStateChangeCallbacks = set() - # cleanStorageRepoitory uses tasksDir value, this must be assigned # before calling it self.tasksDir = config.get('irs', 'hsm_tasks') @@ -401,10 +399,9 @@ @public def registerDomainStateChangeCallback(self, callbackFunc): """ - Currently this method assumes that all registrations - are done *prior* to connecting to pool. + Register a state change callback function with the domain monitor. """ - self.domainStateChangeCallbacks.add(callbackFunc) + self.domainMonitor.onDomainStateChange.register(callbackFunc) def _hsmSchedule(self, name, func, *args): self.taskMng.scheduleJob("hsm", None, vars.task, name, func, *args) @@ -1074,12 +1071,6 @@ else: pool.setBackend( StoragePoolMemoryBackend(pool, masterVersion, domainsMap)) - - # Must register domain state change callbacks *before* connecting - # the pool, which starts domain monitor threads. Otherwise we will - # miss the first event from the monitor thread. - for cb in self.domainStateChangeCallbacks: - pool.domainMonitor.onDomainStateChange.register(cb) res = pool.connect(hostID, msdUUID, masterVersion) if res: -- To view, visit http://gerrit.ovirt.org/35809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28d4f1af4f94da1a8e3511abbe160ea66e81daad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>

3 5

Change in vdsm[ovirt-3.5]: clientIF: Use a weakref.proxy when registering contEIOVMs
by alitke＠redhat.com 02 Dec '14

02 Dec '14

Hello Nir Soffer, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/35808 to review the following change. Change subject: clientIF: Use a weakref.proxy when registering contEIOVMs ...................................................................... clientIF: Use a weakref.proxy when registering contEIOVMs Our storage Event class is taking a weakref on the callback function that is passed into Event.register. Unfortunately weakrefs on bound methods are dead on arrival. See this [1] discussion for more information. Use the same approach as StoragePool._upgradeCallback and use a weakref.proxy to build the callback function. [1] http://code.activestate.com/recipes/81253/ Change-Id: Ib06967b26fc9ace41e5f8305a8fadafbbb0fc4e4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1157421 Signed-off-by: Adam Litke <alitke(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/35436 Reviewed-by: Nir Soffer <nsoffer(a)redhat.com> Reviewed-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/clientIF.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/35808/1 diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py index bb42ee4..3678f9d 100644 --- a/vdsm/clientIF.py +++ b/vdsm/clientIF.py @@ -23,6 +23,8 @@ import time import threading import uuid +from functools import partial +from weakref import proxy import alignmentScan from vdsm.config import config @@ -77,7 +79,8 @@ self._shutdownSemaphore = threading.Semaphore() self.irs = irs if self.irs: - self.irs.registerDomainStateChangeCallback(self.contEIOVms) + self._contEIOVmsCB = partial(clientIF.contEIOVms, proxy(self)) + self.irs.registerDomainStateChangeCallback(self._contEIOVmsCB) self.log = log self._recovery = True self.channelListener = Listener(self.log) -- To view, visit http://gerrit.ovirt.org/35808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib06967b26fc9ace41e5f8305a8fadafbbb0fc4e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>

3 5

Change in vdsm[master]: Revert "use SASL_USERNAME instead of its upstream value"
by Dan Kenigsberg 02 Dec '14

02 Dec '14

Dan Kenigsberg has uploaded a new change for review. Change subject: Revert "use SASL_USERNAME instead of its upstream value" ...................................................................... Revert "use SASL_USERNAME instead of its upstream value" This reverts commit b4da9f55ee0010f516212393f5d0562c59603bd3. Change-Id: Icfe7c7338d3c5cb4e17b9b94ea4fa441c9895e71 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/35801/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 358f15c..7f878c2 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -789,7 +789,7 @@ %{_bindir}/vdsm-tool configure --module sanlock --force >/dev/null # update the vdsm "secret" password for libvirt if [ -f /etc/pki/vdsm/keys/libvirt_password ]; then - @SASLPASSWD2_PATH@ -p -a libvirt @SASL_USERNAME@ < \ + @SASLPASSWD2_PATH@ -p -a libvirt vdsm@ovirt < \ /etc/pki/vdsm/keys/libvirt_password fi -- To view, visit http://gerrit.ovirt.org/35801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icfe7c7338d3c5cb4e17b9b94ea4fa441c9895e71 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

2 4

Change in vdsm[master]: use SASL_USERNAME instead of its upstream value
by Dan Kenigsberg 02 Dec '14

02 Dec '14

Dan Kenigsberg has uploaded a new change for review. Change subject: use SASL_USERNAME instead of its upstream value ...................................................................... use SASL_USERNAME instead of its upstream value commit 98a2692fe reverted broken code, but it also added new code, that the reviewer failed to notice. This patch fixes it. Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1168689 Change-Id: Idf7800e26d95e5da9d64b615de420389bbc7e52f Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/35799/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 7f878c2..358f15c 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -789,7 +789,7 @@ %{_bindir}/vdsm-tool configure --module sanlock --force >/dev/null # update the vdsm "secret" password for libvirt if [ -f /etc/pki/vdsm/keys/libvirt_password ]; then - @SASLPASSWD2_PATH@ -p -a libvirt vdsm@ovirt < \ + @SASLPASSWD2_PATH@ -p -a libvirt @SASL_USERNAME@ < \ /etc/pki/vdsm/keys/libvirt_password fi -- To view, visit http://gerrit.ovirt.org/35799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idf7800e26d95e5da9d64b615de420389bbc7e52f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

3 5

Change in vdsm[master]: sosreport: remove Base class
by ykaplan＠redhat.com 02 Dec '14

02 Dec '14

Yeela Kaplan has uploaded a new change for review. Change subject: sosreport: remove Base class ...................................................................... sosreport: remove Base class Use of Base class inheritance breaks with sos>=3.1 Change-Id: I44816fdfe3197d655dda905c73a50e7c398b2e44 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167828 Signed-off-by: Yeela Kaplan <ykaplan(a)redhat.com> --- M vdsm/sos/vdsm.py.in 1 file changed, 8 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/35759/1 diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in index 535cb7a..02c6c17 100644 --- a/vdsm/sos/vdsm.py.in +++ b/vdsm/sos/vdsm.py.in @@ -20,12 +20,9 @@ try: from sos.plugins import Plugin, RedHatPlugin - - class Base(Plugin, RedHatPlugin): - pass except ImportError: import sos.plugintools - Base = sos.plugintools.PluginBase + Plugin = RedHatPlugin = sos.plugintools.PluginBase import subprocess import os @@ -46,7 +43,7 @@ config = _importVdsmPylibModule('config').config -class vdsm(Base): +class vdsm(Plugin, RedHatPlugin): """VDSM server related information """ @@ -54,12 +51,12 @@ False)] # Make compatible com sos version >= 3 - if not hasattr(Base, 'addCopySpec'): - addCopySpec = Base.add_copy_spec - addCopySpecLimit = Base.add_copy_spec_limit - collectExtOutput = Base.add_cmd_output - getOption = Base.get_option - addForbiddenPath = Base.add_forbidden_path + if not hasattr(Plugin, 'addCopySpec'): + addCopySpec = Plugin.add_copy_spec + addCopySpecLimit = Plugin.add_copy_spec_limit + collectExtOutput = Plugin.add_cmd_output + getOption = Plugin.get_option + addForbiddenPath = Plugin.add_forbidden_path def __addCopySpecLogLimit(self, path, logsize=None): """ -- To view, visit http://gerrit.ovirt.org/35759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I44816fdfe3197d655dda905c73a50e7c398b2e44 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>

4 12

← Newer
1
...
67
68
69
70
71
72
73
74
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches December 2014