Change in vdsm[master]: automation: check-patch: make pylint on each patch
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: automation: check-patch: make pylint on each patch
......................................................................
automation: check-patch: make pylint on each patch
I'm not sure that this long test should be run on each and every patch,
but let us consider this.
Change-Id: Ib4f2f2ec78439ef560b305436160c3140b68e9f2
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M automation/check-patch.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/69346/1
diff --git a/automation/check-patch.sh b/automation/check-patch.sh
index a866771..a401053 100755
--- a/automation/check-patch.sh
+++ b/automation/check-patch.sh
@@ -15,6 +15,7 @@
debuginfo-install -y python
TIMEOUT=600 make check NOSE_WITH_COVERAGE=1 NOSE_COVER_PACKAGE="$PWD/vdsm,$PWD/lib"
+make pylint
# Generate coverage report in HTML format
pushd tests
--
To view, visit https://gerrit.ovirt.org/69346
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4f2f2ec78439ef560b305436160c3140b68e9f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years
Change in vdsm[master]: pylint: Remove broken and unneeded code
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Remove broken and unneeded code
......................................................................
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/75791
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I352e8643a47f517c879d2085bced6847e0372b30
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: net: Move sysctl module under the network package
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Move sysctl module under the network package
......................................................................
Patch Set 2: Code-Review-1
manual rebase needed
--
To view, visit https://gerrit.ovirt.org/75972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I573b4b115f78c08d020272316203122ba1987662
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: net: tool: Relocate restore_nets content
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: tool: Relocate restore_nets content
......................................................................
net: tool: Relocate restore_nets content
Change-Id: I0b8e7fc9d2ddc9433cf4865bf55e225a34aa5ebd
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/api.py
M lib/vdsm/supervdsm_api/network.py
M lib/vdsm/tool/Makefile.am
M lib/vdsm/tool/network.py
D lib/vdsm/tool/restore_nets.py
M vdsm.spec.in
6 files changed, 42 insertions(+), 60 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b8e7fc9d2ddc9433cf4865bf55e225a34aa5ebd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net: Move sysctl module under the network package
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Move sysctl module under the network package
......................................................................
Patch Set 2: Code-Review+2
ok ok, I give up.
--
To view, visit https://gerrit.ovirt.org/75972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I573b4b115f78c08d020272316203122ba1987662
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: net: Embed vdsm-restore-net-config into vdsm.network
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Embed vdsm-restore-net-config into vdsm.network
......................................................................
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/76085/2/lib/vdsm/supervdsm_api/network.py
File lib/vdsm/supervdsm_api/network.py:
Line 23: from vdsm.sysctl import set_rp_filter_loose, set_rp_filter_strict
Line 24: from vdsm.network.api import (setSafeNetworkConfig, setupNetworks,
Line 25: change_numvfs, network_caps, ovs_bridge,
Line 26: add_sourceroute, remove_sourceroute)
Line 27: from vdsm.network.restore_net_config import restore
why you are introducing a new entry point, outside vdsm.network.api?
Line 28: from vdsm.network.tc import setPortMirroring, unsetPortMirroring
Line 29:
Line 30:
Line 31: @expose
https://gerrit.ovirt.org/#/c/76085/2/lib/vdsm/tool/network.py
File lib/vdsm/tool/network.py:
PS2, Line 59: '/etc/vdsm/svdsm.logger.conf'
please replace (in another patch) with vdsm.supervdsm_server.LOG_CONF_PATH
PS2, Line 62: stdout
please replace with stderr
--
To view, visit https://gerrit.ovirt.org/76085
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c3d0ca93179aeb98a89f68265e368d13924f21e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: net: Relocate restore_nets content and remove it
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Relocate restore_nets content and remove it
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8e7fc9d2ddc9433cf4865bf55e225a34aa5ebd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: virt: devices: start the from_xml_tree method
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: devices: start the from_xml_tree method
......................................................................
virt: devices: start the from_xml_tree method
Let's start adding to devices the capability to be initialized
from their XML representation.
The end goal is to make possible to properly initialize a device
from either the usual parameters dictionary or a valid XML snippet.
This is only about device construction, no changes about the
state management whatsoever.
Change-Id: I21e80625f1b86cd5a49571d2e121ee479535d8d3
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/core.py
M tests/virttests/devicexml_test.py
2 files changed, 104 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72880
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21e80625f1b86cd5a49571d2e121ee479535d8d3
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: virt: devices: balloon: add from_xml_tree
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: devices: balloon: add from_xml_tree
......................................................................
virt: devices: balloon: add from_xml_tree
Make it possible to initialize a Balloon device from its
XML representation.
Change-Id: I4c78ff73135e117ddbe64f6e763abd536070bcdc
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/core.py
M tests/virttests/devicexml_test.py
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72881
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c78ff73135e117ddbe64f6e763abd536070bcdc
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: virt: devices: console: add from_xml_tree
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: devices: console: add from_xml_tree
......................................................................
virt: devices: console: add from_xml_tree
Make it possible to initialize a Console device from its
XML representation.
Change-Id: Id99fff24ead20b196556b23b8424b87a7683261c
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/core.py
M tests/virttests/devicexml_test.py
2 files changed, 45 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72882
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id99fff24ead20b196556b23b8424b87a7683261c
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years