Change in vdsm[ovirt-4.1]: net: Introduce the LLDPAD driver with an LLDP interface
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce the LLDPAD driver with an LLDP interface
......................................................................
Patch Set 6: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/80187
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia96dbf46fa656de6c12d495406715519a3d25439
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: Introduce network initializer module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce network initializer module
......................................................................
Patch Set 6: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/80327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9a78d24b6c1cb247397433e02c0bae3e1e7852a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: Enable LLDP on NICs
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Enable LLDP on NICs
......................................................................
Patch Set 8: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/80192
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc0cc21a189bcdcff3f4ac3ad97620ed4ff8f50
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: Add info lldp to lldp
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Add info lldp to lldp
......................................................................
Patch Set 8: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/80193
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9102e4a52de954a97bf0fb7bbb6e85ffd3d992b5
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: Report lldp through new getLldp command
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Report lldp through new getLldp command
......................................................................
Patch Set 10: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/80194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: Report empty LLDP TLV lists for operationally-down inte...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Report empty LLDP TLV lists for operationally-down interfaces
......................................................................
Patch Set 5: Code-Review+2 Verified+1
./run_suite.sh -s http://jenkins.ovirt.org/job/vdsm_4.1_check-patch-el7-x86_64/870/ basic-suite-4.1
is successful, this can go it.
--
To view, visit https://gerrit.ovirt.org/80390
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e6286a576bdf989d8c6d4e44d78297d5888439
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[ovirt-4.1]: vdsm tool configurators: bond_defaults - do not depend on time
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80805 )
Change subject: vdsm tool configurators: bond_defaults - do not depend on time
......................................................................
vdsm tool configurators: bond_defaults - do not depend on time
The bond defaults dump is considered updated if it exists (as it is
created per boot, and its content is dependent on the kernel).
The existing time check (verifying if the period elapsed from the file
update is no older then the time elapsed from the system boot) is no
longer needed, as the dump is placed under /var/run which is assured
to be cleaned on boot.
This patch removes the time checks which are not valid when the time is
updated during the boot.
Change-Id: Ia32455d36d600410a0b792f4e7045b97a08afc70
Bug-Url: https://bugzilla.redhat.com/1482014
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/tool/configurators/bond_defaults.py
1 file changed, 1 insertion(+), 17 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/80805
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia32455d36d600410a0b792f4e7045b97a08afc70
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: place bonding defaults under /var/run
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80804 )
Change subject: net: place bonding defaults under /var/run
......................................................................
net: place bonding defaults under /var/run
vdsm-tool places bonding-defaults.json under /usr/share. However,
the proper place to store application data that is generated every boot
is under /var/run.
Change-Id: Ib50e3c34d54c949ef22e780731518ff17890226f
Bug-Url: https://bugzilla.redhat.com/1482014
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/link/bond/sysfs_options.py
M lib/vdsm/network/netinfo/bonding.py
M lib/vdsm/tool/configurators/bond_defaults.py
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/80804
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib50e3c34d54c949ef22e780731518ff17890226f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[ovirt-4.1]: vdsm tool configurators: bond_defaults - do not depend on time
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm tool configurators: bond_defaults - do not depend on time
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80805
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia32455d36d600410a0b792f4e7045b97a08afc70
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[ovirt-4.1]: net: place bonding defaults under /var/run
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: place bonding defaults under /var/run
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80804
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50e3c34d54c949ef22e780731518ff17890226f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months