Federico Simoncelli has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN ......................................................................
Patch Set 13: I would prefer that you didn't submit this
(1 inline comment)
Minor issue. The rest looks fine to me.
.................................................... File vdsm/storage/glusterSD.py Line 18: return glusterVolume.GlusterVolume Line 19: Line 20: @staticmethod Line 21: def findDomainPath(sdUUID): Line 22: glusterDomPath = os.path.join(sd.GLUSTERSD_DIR + "/*") I don't understand this change. My previous comment was about using os.path.join to build the path:
os.path.join(GLUSTERSD_DIR, "*") Line 23: for tmpSdUUID, domainPath in fileSD.scanDomains(glusterDomPath): Line 24: if tmpSdUUID == sdUUID and mount.isMounted(os.path.join(domainPath, Line 25: "..")): Line 26: return domainPath
-- To view, visit http://gerrit.ovirt.org/6856 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server