Royce Lv has posted comments on this change.
Change subject: Removing vdsm configuration when removing vdsm service ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm.spec.in Line 520: # Removing vdsm configuration from libvirtd.conf and qemu.conf Line 521: /bin/sed -i "/${start_conf_section}/,/${end_conf_section}/d" \ Line 522: /etc/libvirt/libvirtd.conf \ Line 523: /etc/libvirt/qemu.conf \ Line 524: /etc/sysconfig/libvirtd \ And also /etc/libvirt/qemu-sanlock.conf needs to be cleaned. What about use MACRO instead of file paths? Line 525: /etc/sysctl.conf Line 526: Line 527: %if 0%{?rhel} Line 528: if [ "$1" -eq 0 ]
Line 530: /sbin/service vdsmd stop > /dev/null 2>&1 || : Line 531: /sbin/chkconfig --del vdsmd Line 532: Line 533: /bin/sed -i '/# VDSM section begin/,/# VDSM section end/d' \ Line 534: /etc/sysctl.conf I think this line needs to be deleted, they have been done by Line 494-Line499 Line 535: Line 536: %{_bindir}/vdsm-tool sebool-unconfig || : Line 537: Line 538: /usr/sbin/saslpasswd2 -p -a libvirt -d vdsm@ovirt
-- To view, visit http://gerrit.ovirt.org/11295 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f59375e20efa6b5de8483a12a772f5f0ce3749 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server