Igor Lvovsky has posted comments on this change.
Change subject: Add create operation to qemu-img ......................................................................
Patch Set 13: (1 inline comment)
.................................................... File vdsm/qemuImg.py Line 107: cmd.extend(("-f", imgFormat)) Line 108: Line 109: if backingFile: Line 110: #TBD: Escape backing file option? How? Line 111: cmd.extend(("-o", "backing_file=%s" % backingFile)) Sometimes, you will need to know backingFile's format '-F' (mostly for block devices) Line 112: Line 113: cmd.append(filename) Line 114: Line 115: if size is not None:
-- To view, visit http://gerrit.ovirt.org/6245 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I078afcb0899792805584fc56832747d36908f18b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server