Bala.FA has posted comments on this change.
Change subject: getVdsCaps verb is updated to provide glusterfs package info along with other key package details. ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
.................................................... Commit Message Line 3: AuthorDate: 2013-01-11 12:19:50 +0530 Line 4: Commit: Timothy Asir tjeyasin@redhat.com Line 5: CommitDate: 2013-01-17 14:26:40 +0530 Line 6: Line 7: getVdsCaps verb is updated to provide glusterfs package info along Have shorter 1st line and description after a blank line Line 8: with other key package details. Line 9: Line 10: Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635
.................................................... File vdsm/caps.py Line 329: pkgs = {'kernel': kernelDict()} Line 330: Line 331: if getos() in (OSName.RHEVH, OSName.OVIRT, OSName.FEDORA, OSName.RHEL): Line 332: GLUSTER_PACKAGES = ['glusterfs', 'glusterfs-debuginfo', Line 333: 'glusterfs-devel', 'glusterfs-fuse', I think glusterfs-debuginfo and glusterfs-devel are not required Line 334: 'glusterfs-geo-replication', 'glusterfs-rdma', Line 335: 'glusterfs-server', 'glusterfs-swift', Line 336: 'glusterfs-swift-account', Line 337: 'glusterfs-swift-container', 'glusterfs-swift-doc',
-- To view, visit http://gerrit.ovirt.org/11138 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I38991550e57c8f1e558f297cf12d984f7f0bc635 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeyasin@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server