Antoni Segura Puimedon has posted comments on this change.
Change subject: hooks: macbind - Attach vm nics to specified bridge
......................................................................
Patch Set 9: Code-Review-1
(1 comment)
Only one very minor thing, otherwise it is fine.
http://gerrit.ovirt.org/#/c/17895/9/vdsm_hooks/macbind/before_vm_start.py
File vdsm_hooks/macbind/before_vm_start.py:
Line 1: #!/usr/bin/python
this should be
#!/usr/bin/env python2
and have the copyright notice afterwards.
Line 2:
Line 3: import ast
Line 4: import os
Line 5: import sys
--
To view, visit
http://gerrit.ovirt.org/17895
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0356dfab224a9082b44aae1c66df050f7456301c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Humble Devassy Chirammal
hchiramm@redhat.com
Gerrit-Reviewer: Amador Pahim
apahim@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon
asegurap@redhat.com
Gerrit-Reviewer: Aravinda VK
avishwan@redhat.com
Gerrit-Reviewer: Assaf Muller
amuller@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf
dougsland@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli
gvallare@redhat.com
Gerrit-Reviewer: Humble Devassy Chirammal
hchiramm@redhat.com
Gerrit-Reviewer: Mark Wu
wudxw@linux.vnet.ibm.com
Gerrit-Reviewer: Timothy Asir
tjeyasin@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes