Edward Haas has posted comments on this change.
Change subject: build: Disable tests during build ......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/63966/3//COMMIT_MSG Commit Message:
Line 5: CommitDate: 2016-09-15 01:45:00 +0300 Line 6: Line 7: build: Disable tests during build Line 8: Line 9: Tests are needed for development, not for building a package. This
or skip the test on "broken" systems with buggy nose, until nose is fixed.
Sounds like the 'skip' pattern. Being consistent is important, tests should either run or not, either pass or fail. Mixing is not helpful.
I do not see the benefit of testing as part of creating rpms. This is a flow that makes sense to me: [develop]-->[run tests]-->[compile]-->[run all tests]-->[commit]
After that is over, we assume the commits on the branch are stable and fully tested. At that point we go and build the deployment packages. There is no reason to run unit tests at that point, we MUST assume they are ok, otherwise something in the flow is broken. Line 10: allows us to use latest and greatest development tools, which are not Line 11: available in brew or koji. Line 12: Line 13: Since we install nose using pip, remove the build requires - we don't