Ayal Baron has posted comments on this change.
Change subject: prepare volume instead of prepare blockSD ......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/storage/image.py Line 378: Line 379: # Adding the image template to the chain Line 380: tmplVolume = chain[0].getParentVolume() Line 381: Line 382: tmplVolume.prepare() if no template this will be None.prepare() I'm not sure how this worked for you exactly Line 383: Line 384: if tmplVolume: Line 385: chain.insert(0, tmplVolume) Line 386:
Line 389: def teardown(self, sdUUID, imgUUID, volUUID=None): Line 390: chain = self.getChain(sdUUID, imgUUID, volUUID) Line 391: Line 392: tmplVolume = chain[0].getParentVolume() Line 393: tmplVolume.teardown(sdUUID, tmplVolume.volUUID) again, need to check there is a template Line 394: Line 395: def __templateRelink(self, destDom, imgUUID, volUUID): Line 396: """ Line 397: Relink all hardlinks of the template 'volUUID' in all VMs based on it.
-- To view, visit http://gerrit.ovirt.org/8050 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I25b9c260a7de5f883420a5322f90195b3379e80e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com