Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: migration: replace magic number
......................................................................
virt: migration: replace magic number
replace a magic constant with the symbolic name to clarify
the intent of the code.
What the code does is to check the migration job is still active.
The symbolic name was found by checking the docs:
http://libvirt.org/html/libvirt-libvirt.html#virDomainJobInfo
(beware of misalinged comments).
'jobType' can be one of
http://libvirt.org/html/libvirt-libvirt.html#virDomainJobType
Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-on:
http://gerrit.ovirt.org/28356
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/virt/migration.py
1 file changed, 5 insertions(+), 7 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
--
To view, visit
http://gerrit.ovirt.org/28356
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server