ShaoHe Feng has posted comments on this change.
Change subject: extract a method for booting a test VM through kernel boot ......................................................................
Patch Set 7: (1 inline comment)
.................................................... File tests/functional/xmlrpcTests.py Line 161: # Fedora: The initramfs is generated by dracut. The following Line 162: # arguments will be interpreted by init scripts created by Line 163: # dracut. Line 164: 'Fedora': 'rd.break=cmdline rd.shell rd.skipfsck'} Line 165: self.myAssertIn(distro, kernelArgsDistro) does this means that the distro must be 'Fedora'? there is only one item in kernelArgsDistro now, will more items be added to it? Line 166: Line 167: template = {'vmId': '11111111-abcd-2222-ffff-333333333333', Line 168: 'vmName': 'vdsmKernelBootVM', Line 169: 'display': 'vnc',
-- To view, visit http://gerrit.ovirt.org/8414 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6f2e94651d0279b19b1ce6849fb6f0c1b530a10c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com