Ayal Baron has posted comments on this change.
Change subject: Fix mbx Exception type. ......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
.................................................... Commit Message Line 3: AuthorDate: 2013-01-27 09:17:36 +0200 Line 4: Commit: Eduardo Warszawski ewarszaw@redhat.com Line 5: CommitDate: 2013-01-28 10:08:51 +0200 Line 6: Line 7: Fix mbx Exception type. s/mbx/mailbox/g Line 8: Line 9: Making mbx raised exception more precise. Line 10: May be the 1st of an improved mbx logging patches. Line 11:
.................................................... File vdsm/storage/storage_mailbox.py Line 726: # "command: " + str(cmd)) Line 727: (rc, in_mail, err) = misc.execCmd(cmd, sudo=False, raw=True) Line 728: if rc: Line 729: raise IOError(errno.EIO, "_handleRequests._checkForMail - " Line 730: "Could not read mailbox: %s", self._inbox) logging the previous version of the inbox here is misleading and incorrect. Line 731: Line 732: if (len(in_mail) != (self._outMailLen)): Line 733: self.log.error('SPM_MailMonitor: _checkForMail - dd succeeded ' Line 734: 'but read %d bytes instead of %d, cannot check '
-- To view, visit http://gerrit.ovirt.org/6617 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id8baf1121aaf351b029945972d5e87dbfa6a0bd5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server