Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN ......................................................................
Patch Set 8: Fails
This patchset 8 is posted after splitting the prev patchset (no. 7) into multiple different patches, as requested by dan, federico and saggie. See the parent patche(s) trail for the dep. patches.
This patch is on top of the patch which moves gluster/cli and gluster/exception.py from vdsm-gluster to vdsm rpm.
I am putting this -1verify fails, because it works when vdsm-gluster rpm is installed, but gives some exception as below, when vdsm-gluster is not installed.
Thread-49::ERROR::2012-09-21 18:43:28,715::task::833::TaskManager.Task::(_setError) Task=`1a3e49a3-fe55-4c87-b0ce-10a2b6731bd5`::Unexpected error Traceback (most recent call last): File "/usr/share/vdsm/storage/task.py", line 840, in _run return fn(*args, **kargs) File "/usr/share/vdsm/logUtils.py", line 38, in wrapper res = f(*args, **kwargs) File "/usr/share/vdsm/storage/hsm.py", line 2769, in prepareImage 'vmVolInfo': vol.getVmVolumeInfo()} File "/usr/share/vdsm/storage/glusterVolume.py", line 26, in getVmVolumeInfo volInfo = svdsmProxy.glusterVolumeInfo(volname) File "/usr/share/vdsm/supervdsm.py", line 67, in __call__ return callMethod() File "/usr/share/vdsm/supervdsm.py", line 64, in <lambda> getattr(self._supervdsmProxy._svdsm, self._funcName)(*args, AttributeError: 'AutoProxy[instance]' object has no attribute 'glusterVolumeInfo'
I am still investigating this issue.
I wanted to post this patch for review comments from the reviewers, so that they can see the patch post the split, while I investigate on the above excp.
thanx, deepak
-- To view, visit http://gerrit.ovirt.org/6856 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Bala.FA barumuga@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Itamar Heim iheim@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server