Antoni Segura Puimedon has posted comments on this change.
Change subject: Extract bonding options building into a separate function. ......................................................................
Patch Set 5: Fails; I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/configNetwork.py Line 1428: # If the new added network was created on top of Line 1429: # existing bond, we need to keep the bond on rollback Line 1430: # flow, else we will break the new created bond. Line 1431: delNetwork(network, force=True, Line 1432: implicitBonding=networks[network]['bonding'] This will cause a KeyError 'bonding' when a connectivity check fails and one of the networks added is not a bond. I would suggest doing: implicitBonding=networks[network].get('bonding') in bondings Line 1433: in bondings) Line 1434: raise ConfigNetworkError(ne.ERR_LOST_CONNECTION, Line 1435: 'connectivity check failed') Line 1436: except:
-- To view, visit http://gerrit.ovirt.org/8885 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I77fefefcefa05f5bd0d7fa2755357d88b7aa615e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server