Nir Soffer has posted comments on this change.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
......................................................................
Patch Set 4:
(2 comments)
Did you check this with JSONRPC?
I think you need to register these methods in the vdsm/rpc/Bridge.py
http://gerrit.ovirt.org/#/c/29115/4/vdsm/rpc/BindingXMLRPC.py
File vdsm/rpc/BindingXMLRPC.py:
Line 460: api = API.Global()
Line 461: return api.getAllVmStats()
Line 462:
Line 463: def vmGetIoTunePolicy(self, params):
Line 464: vm = API.VM(params['vmId'])
Why not accept vmId like vmGetStats?
Line 465: return vm.getIoTunePolicy()
Line 466:
Line 467: def vmSetIoTune(self, params):
Line 468: vm = API.VM(params['vmId'])
Line 463: def vmGetIoTunePolicy(self, params):
Line 464: vm = API.VM(params['vmId'])
Line 465: return vm.getIoTunePolicy()
Line 466:
Line 467: def vmSetIoTune(self, params):
Why not explicit vmId and tunables arguments?
Line 468: vm = API.VM(params['vmId'])
Line 469: return vm.setIoTune(params['tunables'])
Line 470:
Line 471: def vmMigrationCreate(self, params):
--
To view, visit
http://gerrit.ovirt.org/29115
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cac66eb93b3702b6274b3dfd0816158532effc3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes