Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Replace getVlanDevice/ID in bootstrap with ipwrapper.getLink
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Questioning the original code.
http://gerrit.ovirt.org/#/c/35360/1/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 328: nics = []
Line 329: for iface in ports(bridge):
Line 330: if iface in vlans():
Line 331: iface = _getVlanDevice(iface)
Line 332: vlan = _getVlanID(iface)
Was this even correct? How could _getVlanID return the VLAN ID if it were given the
underlying device name?
Line 333: if iface in bondings():
Line 334: bonding = iface
Line 335: nics = slaves(iface)
Line 336: else:
--
To view, visit
http://gerrit.ovirt.org/35360
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bfb0fa3c341a517bf444832d0531b05393ae4a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes