Dan Kenigsberg has uploaded a new change for review.
Change subject: virt: let Engine start a VM on an UNKOWN OS ......................................................................
virt: let Engine start a VM on an UNKOWN OS
This superflouse validation was introduced as a "bandage" to avoid https://bugzilla.redhat.com/716705, where Vdsm failed to recognize VMs with "UNKOWN" os injected to their bios.
Now that we recognize VMs based on guest channels existence, we can let Engine start a VM on whatever host it deems valid.
Backward compatibility caveat: if a VM is started on an UNKOWN os, and then migrated to an old Vdsm (pre ovirt-3.4.2), it would be killed when that old Vdsm is to be restarted. It's not probable that someone would start a long-running VM on an UNKOWN platform, we may want to wait with this patch until ovirt-3.3 is deprecated.
Change-Id: Iee7b3913e76923043daab8fb85854c3290208237 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/API.py 1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/32459/1
diff --git a/vdsm/API.py b/vdsm/API.py index 8d1bca6..d6f318f 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -237,11 +237,6 @@ vmParams['vmId']) vmParams['volatileFloppy'] = True
- if caps.osversion()['name'] == caps.OSName.UNKNOWN: - return {'status': {'code': errCode['createErr'] - ['status']['code'], - 'message': 'Unknown host operating system'}} - if 'sysprepInf' in vmParams: if not self._createSysprepFloppyFromInf(vmParams['sysprepInf'], vmParams['floppy']):