Dan Kenigsberg has posted comments on this change.
Change subject: lvm: Cleanup lvm udev rules ......................................................................
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/33874/5/vdsm/storage/vdsm_lvm_rules.template.in File vdsm/storage/vdsm_lvm_rules.template.in:
Line 29: # "add" event is processed on coldplug only, so we need "change", too. Line 30: ACTION!="add|change", GOTO="lvm_end" Line 31: Line 32: # Filter out vgs which do not look like a vdsm vg Line 33: ENV{DM_VG_NAME}!="[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]", GOTO="lvm_end"
Maybe a constant for UUID_PATTERN:
autoconf quoting is a bit too much for me to advise about. If you can do it - great.
But I care less about the readability of the generated rule than about the readability of the vdsm_lvm_rules.template python script.
To improve the latter, you don't need autoconf black magic,
HEX='[0-9a-f]' UUID_PATTERN = HEX*8 + '-' + (HEX*4 + '-')*3 + HEX * 12
should be enough. Line 34: Line 35: # Volumes used as vdsm images Line 36: """) Line 37: