Nir Soffer has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
......................................................................
Patch Set 3: Verified+1
It works - and reveal that we have serious threading issue - we get this warning to stderr every few seconds:
Exception RuntimeError: RuntimeError('cannot notify on un-acquired lock',) in <module 'threading' from '/usr/lib64/python2.7/threading.pyc'> ignored
I'm not convinced that we need a signal to open the manhole, and I also never tested this feature.
Please try before your review.
--
To view, visit
http://gerrit.ovirt.org/32147
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a6cdf97ddce446bea527e771eb641f969b1a532
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Allon Mureinik
amureini@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon
asegurap@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Federico Simoncelli
fsimonce@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No