Nir Soffer has posted comments on this change.
Change subject: hsm: prepareForShutdown - operations order ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36162/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py:
Line 3432 Line 3433 Line 3434 Line 3435 Line 3436 I think that it will be more correct to move
self.taskMng.prepareForShutdown()
Before
sp.StoragePool.cleanupMasterMount()
Since you should not access shared storage after you release the locks.
But this will increase the chance that we do not reach the next line, and leave stale locks around, because preparing taskMng for shutdown was too slow and vdsm was killed by the service (after 10 seconds).
We need little more thinking.