Gal Hammer has posted comments on this change.
Change subject: BZ#841555 A migration failure with an "AttributeError" exception. ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 2440: # when migration completes, see qemuMigrationFinish function). Line 2441: # In this case self._dom is None because the function Line 2442: # _waitForIncomingMigrationFinish didn't update it yet. Line 2443: if self._dom: Line 2444: hooks.after_vm_pause(self._dom.XMLDesc(0), self.conf) I don't think that this comment is not relevant to this patch. Line 2445: elif event == libvirt.VIR_DOMAIN_EVENT_RESUMED: Line 2446: self._guestCpuRunning = True Line 2447: if detail == libvirt.VIR_DOMAIN_EVENT_RESUMED_UNPAUSED: Line 2448: hooks.after_vm_cont(self._dom.XMLDesc(0), self.conf)
-- To view, visit http://gerrit.ovirt.org/6901 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server