Dan Kenigsberg has posted comments on this change.
Change subject: configNet: support PREFIX option ......................................................................
Patch Set 2: (1 inline comment)
.................................................... File vdsm/configNetwork.py Line 892: Line 893: if mtu: Line 894: mtu = int(mtu) Line 895: Line 896: prefix = int(options.get('PREFIX')) I never understood why the ALLCAPS form was not good enough for us. Oh well, I will add PREFIX to that conversion.
Putting this conversion (and any excessive logic for that matter...) in bootstrap sounds wrong. Supporting PREFIX in vdsm proper is not hard or dangerous... Line 897: if prefix: Line 898: if netmask is None: Line 899: netmask = _prefix2netmask(prefix) Line 900: del options['PREFIX']
-- To view, visit http://gerrit.ovirt.org/9322 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1d87818642aa2092533f4864728c5ecd5d64f740 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Alon Bar-Lev alonbl@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server