Vinzenz Feenstra has posted comments on this change.
Change subject: tests: add a rollback manager for easy undoing ......................................................................
Patch Set 3: (2 inline comments)
.................................................... File tests/Makefile.am Line 43: permutationTests.py \ Line 44: persistentDictTests.py \ Line 45: restTests.py \ Line 46: restData.py \ Line 47: rollbackManagerTests.py \ I know, but nevertheless it would be a good idea to start with it. Line 48: tcTests.py \ Line 49: vdsClientTests.py \ Line 50: remoteFileHandlerTests.py \ Line 51: resourceManagerTests.py
.................................................... File tests/testrunner.py Line 251: to the list. The function will be put in the "with" statement, the return Line 252: value of the function will be assigned to the "as" variable. If an Line 253: exception is raised, whether it's raised in the function or in the block Line 254: under the "with" statement, the registered undo operations will be played Line 255: in reverse order. When peforming rollback, exceptions will be swalloweded yepp should be swallowed Line 256: to let rollback continue, at last, the earliest exception with original Line 257: line number and stack trace infomation will be raised. Line 258: Line 259: Simple example:
-- To view, visit http://gerrit.ovirt.org/8671 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibc932637dd81c3becf92de34ea647c1cea136111 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com