Peter V. Saveliev has posted comments on this change.
Change subject: migrateStatus() progress report ......................................................................
Patch Set 13: (4 inline comments)
.................................................... File vdsm/vm.py Line 215: Line 216: def _finishSuccessfully(self): Line 217: if self._mode != 'file': Line 218: self._vm.setDownStatus(NORMAL, "Migration succeeded") Line 219: self.status['status']['message'] = 'Migration done' look down. Line 220: else: Line 221: # don't pickle transient params Line 222: for ignoreParam in ('displayIp', 'display', 'pid'): Line 223: if ignoreParam in self._machineParams:
Line 231: self._vm.cif.teardownVolumePath(self._dstparams) Line 232: Line 233: self._vm.setDownStatus(NORMAL, "SaveState succeeded") Line 234: self.status['status']['message'] = 'SaveState done' Line 235: self.status['progress'] = 100 right indent. 100% progress for both cases. Line 236: Line 237: def _patchConfigForLegacy(self): Line 238: """ Line 239: Remove from the VM config drives list "cdrom" and "floppy"
Line 1190: self._migrationSourceThread = \ Line 1191: self.MigrationSourceThreadClass(self, **params) Line 1192: self._migrationSourceThread.start() Line 1193: self._migrationSourceThread.getStat() Line 1194: return self._migrationSourceThread.status no, I don't. It is in progress since the first second — I do not see the usecase of distinguishing «just started» from «started 0.1 secs ago». Line 1195: finally: Line 1196: self._guestCpuLock.release() Line 1197: Line 1198: def migrateStatus(self):
Line 1201: def migrateCancel(self): Line 1202: self._acquireCpuLockWithTimeout() Line 1203: try: Line 1204: self._migrationSourceThread.stop() Line 1205: return self._migrationSourceThread.status filled by MigrationSourceThread Line 1206: except libvirt.libvirtError, e: Line 1207: if e.get_error_code() == libvirt.VIR_ERR_OPERATION_INVALID: Line 1208: return errCode['migCancelErr'] Line 1209: raise
-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server