Yaniv Bronhaim has posted comments on this change.
Change subject: clientIF: Decouple HSM and clientIF
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/clientIF.py
Line 72: self._networkSemaphore = threading.Semaphore()
Line 73: self._shutdownSemaphore = threading.Semaphore()
Line 74: self.irs = irs
Line 75: if self.irs:
Line 76: self.irs.registerDomainStateChangeCallback(self.contEIOVms)
you are right.. why do we still need irs_enable config?? does it mean anything? vdsm
without irs? maybe yes.. but currently if we disable irs we disable vdsm at all
Line 77: self.log = log
Line 78: self._recovery = True
Line 79: self.channelListener = Listener(self.log)
Line 80: self._generationID = str(uuid.uuid4())
--
To view, visit
http://gerrit.ovirt.org/21877
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09aba3638d0dcf5aef73864dd0fe8eae1ced70b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes