Francesco Romani has posted comments on this change.
Change subject: virt: un-memoize getNumaTopology ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
I reviewed the users of this function. It seems we don't have a choice, we must drop the memoziation in every place.
We can do some smart tricks to optimize the access to numa info, but let's save them for future patches.
https://gerrit.ovirt.org/#/c/48006/1/vdsm/caps.py File vdsm/caps.py:
Line 303: Line 304: Line 305: def getNumaTopology(capabilities=None): Line 306: if capabilities is None: Line 307: capabilities = _getCapsXMLStr() this is memoized as well, so we didn't gain that much. Let's have this function call getFreshCapsXml if capabilities is None. Line 308: caps = ET.fromstring(capabilities) Line 309: host = caps.find('host') Line 310: cells = host.find('.//cells') Line 311: cellsInfo = {}