ShaoHe Feng has posted comments on this change.
Change subject: migrateStatus() progress report ......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/vm.py Line 108: libvirtVm = self._connection.lookupByUUID(self._vm.id) Line 109: # jobInfo reference: http://libvirt.org/html/libvirt-libvirt.html#virDomainJobInfo Line 110: (dataTotal, dataProcessed, dataRemaining) = libvirtVm.jobInfo()[3:6] Line 111: # get transfer percentage Line 112: self.status['progress'] = (dataTotal - dataRemaining ) / dataTotal dataTotal is not float. so the percentage is either 0 or 1. Line 113: except: Line 114: pass Line 115: return self.status Line 116:
-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server