Dan Kenigsberg has posted comments on this change.
Change subject: Extend the range of Vm's niceness to allow increasing cpu shares ......................................................................
Patch Set 2:
I agree with Ryan that it would be cleaner to expose cpu shares as a first-class citizen parameter.
Some prehistory: The niceness conversion that you are touching was supposed to be a means to maintain backward compatibility from previous versions of vdsm, which controlled qemu directly. There, it was important to keep all qemus nicer than vdsm itself, hence the lower bound on niceness.
Now, the bounds are a bit arbitrary, and should probably be just circumvented.
-- To view, visit http://gerrit.ovirt.org/6289 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5ae55daa5655dbd10c200dfd81ba80d8e71abfb5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhornyak@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com