ShaoHe Feng has posted comments on this change.
Change subject: migrateStatus() progress report ......................................................................
Patch Set 16: (1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 428: self.data_progress = calculateProgress(dataRemaining, dataTotal) Line 429: self.mem_progress = calculateProgress(memRemaining, memTotal) Line 430: Line 431: self._vm.log.info('Migration Progress: %s seconds elapsed, %s%% of' Line 432: ' data processed, %s%% of mem processed' % Vinzenz: Thank you for making it clear.
Peter: http://www.ovirt.org/Vdsm_Developers. The last rule of "Code Style" in this URL is about logging formatting. Line 433: (timeElapsed / 1000, Line 434: self.data_progress, Line 435: self.mem_progress)) Line 436:
-- To view, visit http://gerrit.ovirt.org/6824 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I3ff00e85c88e865cd81697d427d6bd5473e0f79e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Barak Azulay bazulay@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Peter V. Saveliev peet@redhat.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra evilissimo@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server