Zhou Zheng Sheng has posted comments on this change.
Change subject: extract a method for booting a test VM through kernel boot ......................................................................
Patch Set 5: No score
(1 inline comment)
I will update the patch according to Adam's suggestions.
.................................................... File tests/functional/xmlrpcTests.py Line 54: kernelVer) Line 55: Line 56: if os.path.isfile(initramfsPath): Line 57: # There is an initramfs shipped with the distro, use it Line 58: os.chmod(initramfsPath, 0644) Thanks Adam.
After I install kernel 3.6 rpm, the initramfs is not readable to qemu by default, so I add chmod operation. Now I think it can check the permission and skip if it is not readable to qemu and print a message. Then the admin can modify the permission himself if he wants to run the test actually. Line 59: try: Line 60: yield (kernelPath, initramfsPath) Line 61: finally: Line 62: pass
-- To view, visit http://gerrit.ovirt.org/8414 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I6f2e94651d0279b19b1ce6849fb6f0c1b530a10c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Hunt Xu mhuntxu@gmail.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com