Ryan Harper has posted comments on this change.
Change subject: Added an option to create a watchdog device. ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
I'd like to see this patch series also include changes to qemu.conf with auto_dump_path, and we need to decide where to put guest watchdog dumps as well (on the host). Maybe in the same place as the core files. This needs discussion on vdsm-devel.
Also, I like the idea of only exposing watchdog actions to the vm config instead of being able to add multiple watchdogs and then removing all but one of them. If the user can only specify the action, then multiple calls will only result in one watchdog with whatever the latest action value was passed.
.................................................... File vdsm/libvirtvm.py Line 1195: Create domxml for a watchdog device. Line 1196: Line 1197: <watchdog model='i6300esb' action='dump'> Line 1198: <address type='pci' domain='0x0000' bus='0x00' slot='0x07' Line 1199: function='0x0'/> You should leave out the <address> tag. Libvirt will automatically assign a pci slot for the devices. The code right now will put the watchdog always in slot 0x07 but this may collide with other devices.
Also, have we discussed the default action? Do we always want dump by default? If so, have we updated the vdsm changes to qemu.conf to put dumps in a common location? Line 1200: </watchdog> Line 1201: """ Line 1202: m = self.createXmlElem(self.type, None, ['address']) Line 1203: m.setAttribute('model', self.specParams['model'])
Line 2405: getElementsByTagName('devices')[0]. \ Line 2406: getElementsByTagName('watchdog') Line 2407: for x in watchdogxml: Line 2408: action = x.getAttribute('action') Line 2409: # Ignore watchdog device without address. Why? Line 2410: if not x.getElementsByTagName('address'): Line 2411: continue Line 2412: Line 2413: address = self._getUnderlyingDeviceAddress(x)
-- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Bing Bu Cao mars@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ryanh@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shuming@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server