Change in vdsm[master]: utils: replace order of import for persist/unpersist
Dan Kenigsberg has posted comments on this change.
Change subject: utils: replace order of import for persist/unpersist
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/47829/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 63: persist = Config().persist
Line 64: unpersist = Config().unpersist
Line 65: except ImportError:
Line 66: try:
Line 67: # If failing to import old code, then try importing the legacy code
Please remind me: why do we still need this import at all?
http://gerrit.ovirt.org/33468 does not explain, so I don't know if its reasons are
still relevant.
Please explain in the commit message why this double-import is important, or drop it.
Line 68: from ovirtnode import ovirtfunctions
Line 69: persist = ovirtfunctions.ovirt_store_config
Line 70: unpersist = ovirtfunctions.remove_config
Line 71: except ImportError:
--
To view, visit https://gerrit.ovirt.org/47829
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I51571693d2ff145c1b72b47e28c5c2f09b15acb7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes