Dan Kenigsberg has submitted this change and it was merged.
Change subject: Live Merge: Proactively extend merge target volume ......................................................................
Live Merge: Proactively extend merge target volume
Since libvirt is not yet providing the write watermark information for all volumes, we need to employ a workaround to support live merge on block-based storage. When starting a merge, we can request the base volume (merge target) to be extended to the size of the top volume (merge source) plus one chunk to accomodate active writing. This may cause some over-extension of the merge target volume but the upside is that the merge should complete without active monitoring. Future versions of oVirt will take advantage of an upcoming libvirt enhancement to report write watermarks for all volumes which will allow on-demand volume extension.
Change-Id: I3d483f9dfe6e19a9f9fec84950bf2ea0c7ed7946 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1155583 Signed-off-by: Adam Litke alitke@redhat.com Reviewed-on: http://gerrit.ovirt.org/35614 Reviewed-by: Allon Mureinik amureini@redhat.com Reviewed-by: Francesco Romani fromani@redhat.com Reviewed-by: Federico Simoncelli fsimonce@redhat.com Reviewed-on: http://gerrit.ovirt.org/35573 Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm/virt/vm.py 1 file changed, 26 insertions(+), 71 deletions(-)
Approvals: Adam Litke: Verified Federico Simoncelli: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved