Saggi Mizrahi has posted comments on this change.
Change subject: Use module-specific loggers for network operations. ......................................................................
Patch Set 8: I would prefer that you didn't submit this
I don't really understand the use of logskip.
Just wrapping utils.execCmd with @logskip will log skip as expected.
Apart from that, logs that print tracebacks don't need log skip
Further more logs that point to a state in the operations should keep the original file\line.
Only use log skip on select log message to denote connection in flow.
Using findCaller() might even help produce more insightful connection in the log messages.
-- To view, visit http://gerrit.ovirt.org/7730 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Iea3738f5ce66d2537c078c452def30fb3feb5390 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Meni Yakove myakove@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com