Dan Kenigsberg has posted comments on this change.
Change subject: Expose a custom property for tunnelled migration of a VM ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 430: tunnelled = 0 conf[custom] cannot change after Vm creation, but I do not understand why this means that I must carry another data member, that is only needed when migration starts.
-- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com