Federico Simoncelli has posted comments on this change.
Change subject: [RFC] Support for GLUSTERFS_DOMAIN ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(11 inline comments)
.................................................... File vdsm/libvirtvm.py Line 88: self._vm._dom.blockInfo(vmDrive.path, 0) Did you make sure that this still works with your changes?
Line 991: # Determine if its network type For consistency I'd make this a property as blockDev, something like:
@property def networkDev(self): return self.path['volType'] == "network"
Line 1000: def blockDev(self): We might want to take advantage of volType to skip the utils.isBlockDevice check if we already know that it's not a block device.
Line 1003: self._blockDev = utils.isBlockDevice(self.path['path']) This looks like a repetition:
self.path['path']
You may want to consider an other name, eg: self.volInfo['path']
Line 1521: if drv.path == diskParams['path']: Did you make sure that this still works with your changes?
Line 1875: mergeStatus['path'] = mergeDrive.path Did you make sure that this still works with your changes?
Line 1993: capacity, alloc, physical = self._dom.blockInfo(d.path, 0) Did you make sure that this still works with your changes? ...and so on for all the other .path present in this file and in vm.py (if any).
.................................................... File vdsm/storage/fileSD.py Line 43: OPTIONS = "OPTIONS" I'm not sure if we want to keep this generic as "OPTIONS" or make it specific for what you need. We'll reevaluate later.
.................................................... File vdsm/storage/hsm.py Line 128: sd.GLUSTERFS_DOMAIN: 'posixfs' } Are you sure that this should be 'posixfs'?
.................................................... File vdsm/storage/volume.py Line 294: clsName, "shareVolumeRollback", [dstPath])) Unrelated. As all the other ones.
Line 807: def getVolumePath(self): If this became unused just squash it with getVmVolumeInfo.
-- To view, visit http://gerrit.ovirt.org/6856 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I9ac37da88625f20d148beaf53bb6371c15b33ad7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Deepak C Shetty deepakcs@linux.vnet.ibm.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com